On Sun, 31 May 2026 17:17:22 +0800 Kunwu Chan <[email protected]> wrote:
> From: Kunwu Chan <[email protected]> > > The expectation print has wrong operator precedence: '%' binds > before the conditional expression, so the else branch prints > 'not met' without the prefix 'expectation (>= 14) is'. Add > parentheses to fix it. > > Also, '\n'.join() on the list of ints raises TypeError; > convert to str in the list comprehension. Nice findings and fixes, thank you! > > Co-developed-by: Wang Lian <[email protected]> > Signed-off-by: Wang Lian <[email protected]> > Signed-off-by: Kunwu Chan <[email protected]> checkpatch.pl may warn here like below, and it should be fixed. WARNING: From:/Signed-off-by: email address mismatch: 'From: Kunwu Chan <[email protected]>' != 'Signed-off-by: Kunwu Chan <[email protected]>' Other than that, Reviewed-by: SeongJae Park <[email protected]> Thanks, SJ [...]
