Path-created spawn templates re-open the stored path during spawn-time revalidation. A relative path would be interpreted against the caller cwd at spawn time, not necessarily the cwd used when the template was created.
Reject relative paths for now. Userspace can resolve the executable first or create the template from an executable fd when it needs cwd-relative lookup. Signed-off-by: Li Chen <[email protected]> --- Documentation/userspace-api/spawn_template.rst | 17 ++++++++++++++--- fs/spawn_template.c | 2 ++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/Documentation/userspace-api/spawn_template.rst b/Documentation/userspace-api/spawn_template.rst index 0396d292fd17d..afe215e51db6f 100644 --- a/Documentation/userspace-api/spawn_template.rst +++ b/Documentation/userspace-api/spawn_template.rst @@ -30,9 +30,20 @@ returns a template fd. The fd is an ordinary file descriptor backed by an anonymous inode. Closing the fd releases the template. Userspace can identify the executable either by an existing executable fd or by -path. Exactly one of ``execfd`` and ``filename`` must be supplied. Passing -``SPAWN_TEMPLATE_CREATE_CLOEXEC`` sets ``O_CLOEXEC`` on the returned template -fd. +an absolute path. Exactly one of ``execfd`` and ``filename`` must be supplied. +Passing ``SPAWN_TEMPLATE_CREATE_CLOEXEC`` sets ``O_CLOEXEC`` on the returned +template fd. + +Relative paths are rejected for path-created templates. The kernel stores the +filename and re-opens it at spawn time to check that the path still names the +same executable. A relative filename would be resolved against the caller's +current working directory at spawn time, not the directory that was current +when the template was created. For example, a template created for ``bin/tool`` +while the caller is in ``/repo-a`` could later be spawned after the caller has +changed to ``/repo-b``. Revalidating ``bin/tool`` would then look under +``/repo-b`` and give different semantics from the executable that was +originally templated. Userspace that wants directory-relative lookup should +open the executable itself and create the template from ``execfd``. Creating a template for an unsupported executable format fails. For this RFC that means non-ELF executables fail template creation rather than becoming a diff --git a/fs/spawn_template.c b/fs/spawn_template.c index a11a7ed676416..6430a6645fb57 100644 --- a/fs/spawn_template.c +++ b/fs/spawn_template.c @@ -441,6 +441,8 @@ static int spawn_template_open_filename(u64 filename, struct file **file, tmp = strndup_user(u64_to_user_ptr(filename), PATH_MAX); if (IS_ERR(tmp)) return PTR_ERR(tmp); + if (tmp[0] != '/') + return -EINVAL; kfilename = tmp; tmp_file = open_exec(kfilename); -- 2.52.0
