Hi John! On 5/16/26 2:03 AM, John Hubbard wrote: > On 5/15/26 1:48 AM, Sarthak Sharma wrote: >> Rewrite gup_test.c using kselftest_harness.h. The new test uses >> FIXTURE_VARIANT to cover seven configurations (private/shared, >> read/write, THP, hugetlb) and runs four test cases per variant >> (GUP_BASIC_TEST, PIN_BASIC_TEST, DUMP_USER_PAGES_TEST with get and >> pin), giving 28 TAP-reported cases in total without requiring any >> command-line arguments. >> >> Update run_vmtests.sh: remove run_gup_matrix() and the multiple flagged >> invocations of gup_test, replacing them with a single unconditional >> invocation. Benchmark functionality is handled by tools/mm/gup_bench >> introduced in the previous patch. > > Hi Sarthak, > > Looks like sashiko has a few good observations, these are > worth considering IMHO: > > > https://sashiko.dev/#/patchset/20260515084840.174652-1- > [email protected] > > thanks,
Yes, the observations are valid. I will address them and send out a v2.
