TL; DR: Seems Sashiko is finally convinced. I will drop RFC tag from the next spin.
Forwarding sashiko.dev review status for this thread, with my short comments for issues-may-found reviews. # review url: https://sashiko.dev/#/patchset/[email protected] - [RFC PATCH v5.2 01/11] mm/damon/core: handle <min_region_sz remaining quota as empty - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 02/11] mm/damon/core: merge regions after applying DAMOS schemes - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 03/11] mm/damon/core: introduce failed region quota charge ratio - status: Reviewed - review: ISSUES MAY FOUND Sashiko is asking a same question that I already decided to ignore. - [RFC PATCH v5.2 04/11] mm/damon/sysfs-schemes: implement fail_charge_{num,denom} files - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 05/11] Docs/mm/damon/design: document fail_charge_{num,denom} - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 06/11] Docs/admin-guide/mm/damon/usage: document fail_charge_{num,denom} files - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 07/11] Docs/ABI/damon: document fail_charge_{num,denom} - status: Reviewed - review: ISSUES MAY FOUND For this review, Sashiko seems just hallucinated. - [RFC PATCH v5.2 08/11] mm/damon/tests/core-kunit: test fail_charge_{num,denom} committing - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 09/11] selftests/damon/_damon_sysfs: support failed region quota charge ratio - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 10/11] selftests/damon/drgn_dump_damon_status: support failed region quota charge ratio - status: Reviewed - review: No issues found. - [RFC PATCH v5.2 11/11] selftests/damon/sysfs.py: test failed region quota charge ratio - status: Reviewed - review: No issues found. Thanks, SJ # hkml [1] generated a draft of this mail. It can be regenerated # using below command: # # hkml patch sashiko_dev --thread_status --for_forwarding \ # [email protected] # # [1] https://github.com/sjp38/hackermail
