On 25/03/2026 12:20, Konrad Dybcio wrote:
On 3/24/26 7:08 PM, David Heidelberg wrote:
On 24/03/2026 14:12, Konrad Dybcio wrote:
On 3/24/26 12:20 AM, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
Definition of the NFC.
"meh" commit message
[...]
+ nfc_enable_default: nfc-enable-default-state {
+ pins = "gpio12", "gpio62";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
bias-disable;
Are you sure about pulling up an active-high pin?
I'm not sure, but downstream does it (and "works for me"). Maybe Alexander
would know more details here.
Would changing it to bias-disable also "work for you"?
Yeah, works for me. Should OnePlus 6 do the same?
Looking at OP6 datasheet, there is no pull-up/down on 12,62,nor IRQ 63.
David
David
FWIW TLMM subnodes are best sorted by pin index (although the file
currently doesn't really do that) as per dts coding style
I assume when I group the -pins into -state it doesn't apply anymore? As I
don't feel having pins relevant to one device / subsystem all over the place is
extra clean.
Krzysztof?
Konrad
--
David Heidelberg
