On 20/03/2026 04:18, Xiangzhi Tang wrote: > Add the new binding document for MediaTek Video Companion > Processor(VCP) on MediaTek mt8196.
This wasn't tested/checked, so only limited review. Please do not send untested code. ... > + mboxes: > + maxItems: 5 You need to list the items > + > + mbox-names: > + maxItems: 5 You need to list the items. Open any binding - there is no such syntax alone, right? > + > + power-domains: > + maxItems: 1 > + > + iommus: > + description: > + Using MediaTek iommu to apply larb ports for Multimedia Memory > + Management Unit and address translation > + Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml > + maxItems: 1 > + > + memory-region: > + maxItems: 1 > + > +patternProperties: > + "^vcp@[a-f0-9]+$": > + type: object > + description: > + The MediaTek VCP integrated to SoC might be a multi-core version. > + The other cores are represented as child nodes of the boot core. > + There are some integration differences for the IP like the usage of > + address translator for translating SoC bus addresses into address > + space for the processor. > + > + The SRAM are shared by all cores, each VCP core only using a piece > + SRAM memory. The power of SRAM should be enabled before booting VCP > cores. > + The size of SRAM are varied on differnt SoCs. > + > + The VCP cores has differences on different SoCs to support for > + Hart. > + > + properties: > + compatible: > + enum: > + - mediatek,vcp-core > + > + reg: > + description: The base address and size of SRAM. > + maxItems: 1 > + > + reg-names: > + const: sram > + > + mtk,vcp-core-twohart: There is no such company or prefix as mtk. You already received feedback for this. > + enum: [0, 1] > + $ref: /schemas/types.yaml#/definitions/uint32 What is the point of this property? Best regards, Krzysztof
