On Wed, Mar 18, 2026 at 11:32:10AM +0000, Lorenzo Stoakes (Oracle) wrote: > On Wed, Mar 18, 2026 at 05:22:40PM +0800, Chunyu Hu wrote: > > For question one. In guard-region test, collapse tests are for checking > > collapse is denied when operating on guard region, not for checking > > madvise(MADV_COLLAPSE) will fail when thp is setup to 'never with sysfs, > > No, if thp is set to never, madvise(MADV_COLLAPSE) still succeeds. This is a > source of confusion for many :)
You are right. Thanks for correcting me. > > > result is same, but it's a different test. Maybe we don't have strong > > interest to test when thp is set to 'never' in this collapse test. > > Do you perfer we let it run when thp is setup with 'never'? > > Yes because it should still function then :) Sure. Let me send a v4 to change to thp_available(). > > Cheers, Lorenzo >
