Hi Arnd, On Sat, 14 Mar 2026 at 16:42, Arnd Bergmann <[email protected]> wrote: > I don't think this is safe to do in portable code
:( > diff --git a/arch/m68k/include/asm/io_no.h b/arch/m68k/include/asm/io_no.h > index 516371d5587a..c39db8798ef2 100644 > --- a/arch/m68k/include/asm/io_no.h > +++ b/arch/m68k/include/asm/io_no.h > @@ -96,15 +96,6 @@ static inline void writel(u32 value, volatile void __iomem > *addr) > __raw_writel(swab32(value), addr); > } > > -#else > - > -#define readb __raw_readb > -#define readw __raw_readw > -#define readl __raw_readl > -#define writeb __raw_writeb > -#define writew __raw_writew > -#define writel __raw_writel > - > #endif /* IOMEMBASE */ > > #if defined(CONFIG_PCI) > > Can you try if this works? This builds but doesn't boot on my devicetree'd dragonball branch. I don't think it's possible to boot the stuff that is in mainline (and you wouldn't know if it booted or not due to the lack of a serial driver). I think I can fix my stuff so it works with the changes in readl() etc but I think there are a few other people that have their own 68000 trees for weird custom boards and I guess this might break their stuff. Not saying we should force a change onto virtio-mmio because of weird hobby projects. Not sure what to do. Thanks, Daniel
