On 3/10/26 12:03 AM, Daniel Lezcano wrote: > The QMI framework proposes a set of services which are defined by an > integer identifier. The different QMI client lookup for the services > via this identifier. Moreover, the function qmi_add_lookup() and > qmi_add_server() must match the service ID but the code in different > places set the same value but with a different macro name. These > macros are spreaded across the different subsystems implementing the > protocols associated with a service. It would make more sense to > define them in the QMI header for the sake of consistency and clarity. > > This change use an unified naming for the services and enumerate the > ones implemented in the Linux kernel. More services can come later and > put the service ID in this same header. > > Signed-off-by: Daniel Lezcano <[email protected]> > --- > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h > index 291cdc7ef49c..b8d07f2c07e7 100644 > --- a/include/linux/soc/qcom/qmi.h > +++ b/include/linux/soc/qcom/qmi.h > @@ -92,6 +92,18 @@ struct qmi_elem_info { > #define QMI_ERR_INCOMPATIBLE_STATE_V01 90 > #define QMI_ERR_NOT_SUPPORTED_V01 94 > > +/* > + * Enumerate the IDs of the QMI services
In case that's useful: https://github.com/linux-msm/qrtr/blob/master/src/lookup.c#L23 Konrad
