On 2/27/2026 1:12 AM, Krzysztof Kozlowski wrote:
On 13/02/2026 02:22, Shawn Guo wrote:
On Wed, Dec 24, 2025 at 09:34:30AM +0100, Krzysztof Kozlowski wrote:
the interrupt for soccp is defined as
"wdog","fatal","ready","handover","stop-ack","pong","wake-ack"
while other pas could be:
"wdog","fatal","ready","handover","stop-ack","shutdown-ack"
so grow existing list is not work for this,
In the v1, got your comments to adjust pas-common.yaml for the interrupt:
https://lore.kernel.org/all/[email protected]/
and in v2, interrupt are moved as part to the "allOf" with if-else and
also got NAK:
https://lore.kernel.org/all/20251030-venomous-apricot-falcon-b3fd64@kuoka/
Could you please share a example for us to understand how to maintain it in
pas-common.yaml, not define if-else and has strict order at the same time?
That will be very helpful.
I guess something like this would work?
interrupt-names:
minItems: 5
maxItems: 7
oneOf:
- items:
- const: wdog
- const: fatal
- const: ready
- const: handover
- const: stop-ack
- const: shutdown-ack
- items:
- const: wdog
- const: fatal
- const: ready
- const: handover
- const: stop-ack
- const: pong
- const: wake-ack
This is good for pas-common, but you also need in the same commit update
all schemas having $ref to pas-common to have explicit list. For example
milos has six elements and your change would basically allow the sixth
item to be pong.
Also several files need maxItems for interrupts, since the upper limit
is now 7.
Best regards,
Krzysztof
Hi Krzysztof,
Here are our understanding for this, Shawn propose:
Option 1, use "oneof" in pas-common
we currently have following files having $ref to pas-common:
qcom,qcs404-pas.yaml
qcom,sdx55-pas.yaml
qcom,sc8280xp-pas.yaml
qcom,sm6115-pas.yaml
qcom,sm6350-pas.yaml
qcom,sm6375-pas.yaml
qcom,adsp.yaml
qcom,milos-pas.yaml
qcom,sa8775p-pas.yaml
qcom,sc7180-pas.yaml
qcom,sm8150-pas.yaml
qcom,sm8350-pas.yaml
modifying pas-common means we need to add explicit list in each file,
(also we need to add constraint for smem-state)
To avoid affecting the existing yaml bindings, we assume below
Option2: have a new common file for soccp yaml with "pong"
interrupt along with 4 corresponding "smem-state"
the example will be like:
kaanapali-soccp.yaml ref with soccp-common.yaml. and the common yaml
will be very much pas-common.yaml content, while the interrupt and
smem state will be updated.
Could you please help to have a suggestion for Option 1 or Option 2?
Thanks,
Jingyi
