On Tue, Nov 11, 2025 at 01:45:56PM +0100, Arnd Bergmann wrote:
> On Tue, Nov 11, 2025, at 11:49, Thomas Weißschuh wrote:
> > +/*
> > + * UAPI headers from the libc may be older and not provide these.
> > + */
> > +#if KERNEL_VERSION(5, 5, 0) > LINUX_VERSION_CODE
> > +typedef __kernel_long_t            __kernel_old_time_t;
> > +
> > +struct __kernel_old_timespec {
> > +   __kernel_old_time_t     tv_sec;
> > +   long                    tv_nsec;
> > +};
> > +#endif
> 
> Doesn't this also need to define __kernel_old_timeval, which you
> refer to below?

It was added in 4.17, so it is present in the 4.19.88 headers my musl
ships with. I can add it for completeness.

> > +typedef __kernel_time_t (*vdso_time_t)(__kernel_time_t *t);
> 
> This I think needs to be __kernel_old_time_t instead of __kernel_time_t.

Indeed, thanks. The only user assigns the return value to a 'long' and
doesn't use the pointer argument. So for now it doesn't matter.
I'll add a proper test for it.


Thomas

Reply via email to