On Thu, Nov 06, 2025 at 11:30:32AM +0800, Peng Fan wrote: > Allow each platform to provide its own implementation of start/stop/ > detect_mode operations, and prepare to eliminate the need for multiple > switch-case statements. > > Improve code readability and maintainability by encapsulating > platform-specific behavior. > > No functional changes. > > Reviewed-by: Daniel Baluta <[email protected]> > Reviewed-by: Shengjiu Wang <[email protected]> > Signed-off-by: Peng Fan <[email protected]>
Reviewed-by: Frank Li <[email protected]> > --- > drivers/remoteproc/imx_dsp_rproc.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c > b/drivers/remoteproc/imx_dsp_rproc.c > index > 1726aaa1eafb9ac1a913e3e2caea73801b86dc09..833b1bd4019614157f0bedf09bd348caab802eef > 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -404,6 +404,11 @@ static int imx_dsp_rproc_start(struct rproc *rproc) > struct device *dev = rproc->dev.parent; > int ret; > > + if (dcfg->ops && dcfg->ops->start) { > + ret = dcfg->ops->start(rproc); > + goto start_ret; > + } > + > switch (dcfg->method) { > case IMX_RPROC_MMIO: > ret = regmap_update_bits(priv->regmap, > @@ -424,6 +429,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) > return -EOPNOTSUPP; > } > > +start_ret: > if (ret) > dev_err(dev, "Failed to enable remote core!\n"); > else if (priv->flags & WAIT_FW_READY) > @@ -449,6 +455,11 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) > return 0; > } > > + if (dcfg->ops && dcfg->ops->stop) { > + ret = dcfg->ops->stop(rproc); > + goto stop_ret; > + } > + > switch (dcfg->method) { > case IMX_RPROC_MMIO: > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > dcfg->src_mask, > @@ -467,6 +478,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) > return -EOPNOTSUPP; > } > > +stop_ret: > if (ret) > dev_err(dev, "Failed to stop remote core\n"); > else > @@ -1085,10 +1097,14 @@ static int imx_dsp_attach_pm_domains(struct > imx_dsp_rproc *priv) > static int imx_dsp_rproc_detect_mode(struct imx_dsp_rproc *priv) > { > const struct imx_dsp_rproc_dcfg *dsp_dcfg = priv->dsp_dcfg; > + const struct imx_rproc_dcfg *dcfg = dsp_dcfg->dcfg; > struct device *dev = priv->rproc->dev.parent; > struct regmap *regmap; > int ret = 0; > > + if (dcfg->ops && dcfg->ops->detect_mode) > + return dcfg->ops->detect_mode(priv->rproc); > + > switch (dsp_dcfg->dcfg->method) { > case IMX_RPROC_SCU_API: > ret = imx_scu_get_handle(&priv->ipc_handle); > > -- > 2.37.1 >
