On Fri, Oct 31, 2025 at 05:08:31PM +0800, Peng Fan wrote: > Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which > ties the remoteproc lifecycle to the device's lifecycle. This simplifies > error handling and ensures proper cleanup. > > No functional changes. > > Signed-off-by: Peng Fan <[email protected]> > ---
Reviewed-by: Frank Li <[email protected]> > drivers/remoteproc/imx_dsp_rproc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c > b/drivers/remoteproc/imx_dsp_rproc.c > index > c466363debbebe8f91b908b3bffaa32e9bf8b9a6..df6a4126538d22ff6e02145edb5ac13c2d72c949 > 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device > *pdev) > > init_completion(&priv->pm_comp); > rproc->auto_boot = false; > - ret = rproc_add(rproc); > + ret = devm_rproc_add(dev, rproc); > if (ret) > return dev_err_probe(dev, ret, "rproc_add failed\n"); > > @@ -1211,7 +1211,6 @@ static void imx_dsp_rproc_remove(struct platform_device > *pdev) > struct imx_dsp_rproc *priv = rproc->priv; > > pm_runtime_disable(&pdev->dev); > - rproc_del(rproc); > } > > /* pm runtime functions */ > > -- > 2.37.1 >
