On 10/30/25 1:03 PM, David Heidelberg wrote:
> On 30/10/2025 12:32, Konrad Dybcio wrote:
>> On 10/30/25 8:24 AM, David Heidelberg via B4 Relay wrote:
>>> From: David Heidelberg <[email protected]>
[...]
>>> + battery: battery {
>>> + compatible = "simple-battery";
>>> +
>>> + status = "disabled";
>>
>> You added support for both non-proto boards based on this platform,
>> there is no usecase for you to disable the battery, remove this line
>
> Should I keep the status = "okay" in the board files or drop it too?
Drop it, nodes are enabled unless they're explicitly disabled
[...]
>>> +&tlmm {
>>> + gpio-reserved-ranges = <0 4>, <81 4>;
>>
>> Could you add a comment (like in x1-crd.dtsi) mentioning what these
>> pins correspond to? Usually it's a fingerprint scanner or things like
>> that
>
> Sure, I looked into it, but I haven't found (so far) information about the
> assigned blocks. In next revision it'll be addressed :)>
Thanks, you can usually correlate them to a QUP instance based on the pinctrl
Konrad
