Hi Siddharth, kernel test robot noticed the following build errors:
[auto build test ERROR on arnd-asm-generic/master] [also build test ERROR on soc/for-next linus/master v6.18-rc2 next-20251022] [cannot apply to mcgrof/modules-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Siddharth-Nayyar/define-kernel-symbol-flags/20251021-104658 base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master patch link: https://lore.kernel.org/r/20251013153918.2206045-11-sidnayyar%40google.com patch subject: [PATCH v2 10/10] module loader: enforce symbol import protection config: x86_64-randconfig-122-20251022 (https://download.01.org/0day-ci/archive/20251023/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): kernel/module/main.c: In function 'resolve_symbol': >> kernel/module/main.c:1271:37: error: 'struct module' has no member named >> 'sig_ok' 1271 | if (fsa.is_protected && !mod->sig_ok) { | ^~ vim +1271 kernel/module/main.c 1228 1229 /* Resolve a symbol for this module. I.e. if we find one, record usage. */ 1230 static const struct kernel_symbol *resolve_symbol(struct module *mod, 1231 const struct load_info *info, 1232 const char *name, 1233 char ownername[]) 1234 { 1235 struct find_symbol_arg fsa = { 1236 .name = name, 1237 .gplok = !(mod->taints & (1 << TAINT_PROPRIETARY_MODULE)), 1238 .warn = true, 1239 }; 1240 int err; 1241 1242 /* 1243 * The module_mutex should not be a heavily contended lock; 1244 * if we get the occasional sleep here, we'll go an extra iteration 1245 * in the wait_event_interruptible(), which is harmless. 1246 */ 1247 sched_annotate_sleep(); 1248 mutex_lock(&module_mutex); 1249 if (!find_symbol(&fsa)) 1250 goto unlock; 1251 1252 if (fsa.license == GPL_ONLY) 1253 mod->using_gplonly_symbols = true; 1254 1255 if (!inherit_taint(mod, fsa.owner, name)) { 1256 fsa.sym = NULL; 1257 goto getname; 1258 } 1259 1260 if (!check_version(info, name, mod, fsa.crc)) { 1261 fsa.sym = ERR_PTR(-EINVAL); 1262 goto getname; 1263 } 1264 1265 err = verify_namespace_is_imported(info, fsa.sym, mod); 1266 if (err) { 1267 fsa.sym = ERR_PTR(err); 1268 goto getname; 1269 } 1270 > 1271 if (fsa.is_protected && !mod->sig_ok) { 1272 pr_warn("%s: Cannot use protected symbol %s\n", 1273 mod->name, name); 1274 fsa.sym = ERR_PTR(-EACCES); 1275 goto getname; 1276 } 1277 1278 err = ref_module(mod, fsa.owner); 1279 if (err) { 1280 fsa.sym = ERR_PTR(err); 1281 goto getname; 1282 } 1283 1284 getname: 1285 /* We must make copy under the lock if we failed to get ref. */ 1286 strscpy(ownername, module_name(fsa.owner), MODULE_NAME_LEN); 1287 unlock: 1288 mutex_unlock(&module_mutex); 1289 return fsa.sym; 1290 } 1291 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
