On Wed 2025-10-22 10:28:04, Petr Pavlu wrote:
> The TAINT_RANDSTRUCT and TAINT_FWCTL flags are mistakenly set in the
> taint_flags table as per-module flags. While this can be trivially
> corrected, the issue can be avoided altogether by removing the
> taint_flag.module field.
>
> This is possible because, since commit 7fd8329ba502 ("taint/module: Clean
> up global and module taint flags handling") in 2016, the handling of module
> taint flags has been fully generic. Specifically, module_flags_taint() can
> print all flags, and the required output buffer size is properly defined in
> terms of TAINT_FLAGS_COUNT. The actual per-module flags are always those
> added to module.taints by calls to add_taint_module().
>
> Signed-off-by: Petr Pavlu <[email protected]>
Makes sense. Nice trick!
Acked-by: Petr Mladek <[email protected]>
Best Regards,
Petr
