>clang warning null passed where non-null argument is expected. > >anon_inode_test.c:45:19: warning: argument 3 null where non-null expected >[-Wnonnull] > 45 | ASSERT_LT(execveat(fd_context, "", NULL, NULL, AT_EMPTY_PATH), > 0); > | ^~~~~~~~ > >Signed-off-by: Ranganath V N <[email protected]> >--- >Adding missed mainters to the patch > > tools/testing/selftests/filesystems/anon_inode_test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c >b/tools/testing/selftests/filesystems/anon_inode_test.c >index 73e0a4d4fb2f..f796dad679db 100644 >--- a/tools/testing/selftests/filesystems/anon_inode_test.c >+++ b/tools/testing/selftests/filesystems/anon_inode_test.c >@@ -38,11 +38,13 @@ TEST(anon_inode_no_chmod) > TEST(anon_inode_no_exec) > { > int fd_context; >+ static char *argv[] = { NULL }; >+ static char *envp[] = { NULL }; > > fd_context = sys_fsopen("tmpfs", 0); > ASSERT_GE(fd_context, 0); > >- ASSERT_LT(execveat(fd_context, "", NULL, NULL, AT_EMPTY_PATH), 0); >+ ASSERT_LT(execveat(fd_context, "", argv, envp, AT_EMPTY_PATH), 0); > ASSERT_EQ(errno, EACCES); > > EXPECT_EQ(close(fd_context), 0);
Hi Christian Brauner, I just wanted to kindlyfollow up on this patch. I'd appreicate any feedback or comments when you have chance. Regards, Rangaanth
