Sometimes clients need to know if mailbox queue is full or not before posting new message via mailbox. If mailbox queue is full clients can choose not to post new message. This doesn't mean current queue length should be increased, but clients may want to wait till previous Tx is done. Introduce variable per channel to track available msg slots. Clients can check this variable and decide not to send new message if it is 0. This can help avoid false positive warning from mailbox framework "Try increasing MBOX_TX_QUEUE_LEN".
Signed-off-by: Tanmay Shah <[email protected]> --- v2: - Separate patch for remoteproc subsystem. - Change design and introduce msg_slot_ro field for each channel instead of API. Clients can use this variable directly. - Remove mbox_queue_full API drivers/mailbox/mailbox.c | 3 +++ include/linux/mailbox_controller.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 5cd8ae222073..c2e187aa5d22 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -35,6 +35,7 @@ static int add_to_rbuf(struct mbox_chan *chan, void *mssg) idx = chan->msg_free; chan->msg_data[idx] = mssg; chan->msg_count++; + chan->msg_slot_ro = (MBOX_TX_QUEUE_LEN - chan->msg_count); if (idx == MBOX_TX_QUEUE_LEN - 1) chan->msg_free = 0; @@ -70,6 +71,7 @@ static void msg_submit(struct mbox_chan *chan) if (!err) { chan->active_req = data; chan->msg_count--; + chan->msg_slot_ro = (MBOX_TX_QUEUE_LEN - chan->msg_count); } } @@ -318,6 +320,7 @@ static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl) scoped_guard(spinlock_irqsave, &chan->lock) { chan->msg_free = 0; chan->msg_count = 0; + chan->msg_slot_ro = MBOX_TX_QUEUE_LEN; chan->active_req = NULL; chan->cl = cl; init_completion(&chan->tx_complete); diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h index ad01c4082358..514f10fbcd42 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -112,6 +112,7 @@ struct mbox_controller { * @msg_count: No. of mssg currently queued * @msg_free: Index of next available mssg slot * @msg_data: Hook for data packet + * @msg_slot_ro: remaining message slots in the queue. * @lock: Serialise access to the channel * @con_priv: Hook for controller driver to attach private data */ @@ -123,6 +124,7 @@ struct mbox_chan { void *active_req; unsigned msg_count, msg_free; void *msg_data[MBOX_TX_QUEUE_LEN]; + unsigned int msg_slot_ro; spinlock_t lock; /* Serialise access to the channel */ void *con_priv; }; -- 2.34.1
