On Fri, Oct 10, 2025 at 11:30:43AM +0800, Wang Liang wrote: > The jq command is used in vlan_bridge_binding.sh, if it is not supported, > the test will spam the following log. > > # ./vlan_bridge_binding.sh: line 51: jq: command not found > # ./vlan_bridge_binding.sh: line 51: jq: command not found > # ./vlan_bridge_binding.sh: line 51: jq: command not found > # ./vlan_bridge_binding.sh: line 51: jq: command not found > # ./vlan_bridge_binding.sh: line 51: jq: command not found > # TEST: Test bridge_binding on->off when lower down [FAIL] > # Got operstate of , expected 0 > > The rtnetlink.sh has the same problem. It makes sense to check if jq is > installed before running these tests. After this patch, the > vlan_bridge_binding.sh skipped if jq is not supported: > > # timeout set to 3600 > # selftests: net: vlan_bridge_binding.sh > # TEST: jq not installed [SKIP] > > Signed-off-by: Wang Liang <[email protected]> > --- > tools/testing/selftests/net/rtnetlink.sh | 2 ++ > tools/testing/selftests/net/vlan_bridge_binding.sh | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/net/rtnetlink.sh > b/tools/testing/selftests/net/rtnetlink.sh > index dbf77513f617..163a084d525d 100755 > --- a/tools/testing/selftests/net/rtnetlink.sh > +++ b/tools/testing/selftests/net/rtnetlink.sh > @@ -1466,6 +1466,8 @@ usage: ${0##*/} OPTS > EOF > } > > +require_command jq > + > #check for needed privileges > if [ "$(id -u)" -ne 0 ];then > end_test "SKIP: Need root privileges" > diff --git a/tools/testing/selftests/net/vlan_bridge_binding.sh > b/tools/testing/selftests/net/vlan_bridge_binding.sh > index db481af9b6b3..e8c02c64e03a 100755 > --- a/tools/testing/selftests/net/vlan_bridge_binding.sh > +++ b/tools/testing/selftests/net/vlan_bridge_binding.sh > @@ -249,6 +249,8 @@ test_binding_toggle_off_when_upper_down() > do_test_binding_off : "on->off when upper down" > } > > +require_command jq > + > trap defer_scopes_cleanup EXIT > setup_prepare > tests_run > -- > 2.34.1 >
Reviewed-by: Hangbin Liu <[email protected]>
