Alison Schofield wrote: > On Sun, Sep 28, 2025 at 09:31:10AM +0800, Jiapeng Chong wrote: > > ./drivers/nvdimm/bus.c: linux/slab.h is included more than once. > > Hi Jiapeng, > > It would have been useful here to note where else slab.h was included, > since it wasn't simply a duplicate #include in bus.c.
Actually Alison this is a bug against linux-next where it was an issue with Dave's patch here: https://lore.kernel.org/all/[email protected]/ I'll queue this up. Reviewed-by: Ira Weiny <[email protected]> Thanks, Ira > > I found slab.h is also in #include <linux/fs.h>. Then I found that this > compiles if I remove both of those includes. It would be worthwhile to > check all the includes and send a new tested version of this patch that > does this "Remove needless #include's in bus.c" > > BTW - I didn't check all #includes.There may be more beyond slab.h & fs.h. > > --Alison > > > > > Reported-by: Abaci Robot <[email protected]> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=25516 > > Signed-off-by: Jiapeng Chong <[email protected]> > > --- > > drivers/nvdimm/bus.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > > index ad3a0493f474..87178a53ff9c 100644 > > --- a/drivers/nvdimm/bus.c > > +++ b/drivers/nvdimm/bus.c > > @@ -13,7 +13,6 @@ > > #include <linux/async.h> > > #include <linux/ndctl.h> > > #include <linux/sched.h> > > -#include <linux/slab.h> > > #include <linux/cpu.h> > > #include <linux/fs.h> > > #include <linux/io.h> > > -- > > 2.43.5 > > > >
