On Fri, Oct 17, 2025 at 05:07:03PM -0700, Vipin Sharma wrote: > Set skip_kexec_clear_master on live update prepare() so that the device > participating in live update can continue to perform DMA during kexec > phase.
Instead of introducing the skip_kexec_clear_master flag, could you introduce a function to check whether a device participates in live update and call that in pci_device_shutdown()? I think that would be cleaner. Otherwise someone reading the code has to chase down the meaning of skip_kexec_clear_master, i.e. search for places where the bit is set. When the device is unbound from vfio-pci, don't you have to clear the skip_kexec_clear_master flag? I'm not seeing this in your patches but maybe I'm missing something. That problem would solve itself if you follow the suggestion above. Thanks, Lukas
