Re: [PATCH V3 05/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

[Neeraj Kumar]

On 19/09/25 04:59PM, Dave Jiang wrote:

On 9/17/25 6:41 AM, Neeraj Kumar wrote:

CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5
Modified __pmem_label_update function using setter functions to update
namespace label as per CXL LSA 2.1

Signed-off-by: Neeraj Kumar <s.nee...@samsung.com>
---
 drivers/nvdimm/label.c |  3 +++
 drivers/nvdimm/nd.h    | 23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index 3235562d0e1c..182f8c9a01bf 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
+static inline void nsl_set_type(struct nvdimm_drvdata *ndd,
+                               struct nd_namespace_label *ns_label)
+{
+       if (ndd->cxl && ns_label)
+               uuid_parse(CXL_NAMESPACE_UUID, (uuid_t *) ns_label->cxl.type);

Personally would prefer something like:

if (!(ndd->cxl && ns_label))
        return;
uuid_parse(....);

Also, no space needed after casting.

+}
+
+static inline void nsl_set_alignment(struct nvdimm_drvdata *ndd,
+                                    struct nd_namespace_label *ns_label,
+                                    u32 align)
+{
+       if (ndd->cxl)
+               ns_label->cxl.align = __cpu_to_le32(align);

same comment as above

+}
+
+static inline void nsl_set_region_uuid(struct nvdimm_drvdata *ndd,
+                                      struct nd_namespace_label *ns_label,
+                                      const uuid_t *uuid)
+{
+       if (ndd->cxl && uuid)
+               export_uuid(ns_label->cxl.region_uuid, uuid);

same comment as above

Sure Dave, I will fix it in next patch-set


Regards,
Neeraj