On Tue, Sep 30, 2025 at 12:09:01PM -0700, Florian Fainelli wrote: > On 9/30/25 12:03, Conor Dooley wrote: > > On Mon, Sep 29, 2025 at 04:06:24PM -0400, Kamal Dasu wrote: > > > Adding brcmstb-hwspinlock bindings. > > > > > > Signed-off-by: Kamal Dasu <[email protected]> > > > --- > > > .../hwlock/brcm,brcmstb-hwspinlock.yaml | 36 +++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml > > > b/Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml > > > new file mode 100644 > > > index 000000000000..f45399b4fe0b > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/hwlock/brcm,brcmstb-hwspinlock.yaml > > > @@ -0,0 +1,36 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/hwlock/brcm,brcmstb-hwspinlock.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Broadcom settop Hardware Spinlock > > > + > > > +maintainers: > > > + - Kamal Dasu <[email protected]> > > > + > > > +properties: > > > + compatible: > > > + const: brcm,brcmstb-hwspinlock > > > > Is "brcmstb" actually the name of a single platform? > > Looking at the "brcmstb" pci binding, it looks like there's a whole load > > of different devices there and none use "brcmstb": > > - brcm,bcm2711-pcie # The Raspberry Pi 4 > > - brcm,bcm2712-pcie # Raspberry Pi 5 > > - brcm,bcm4908-pcie > > - brcm,bcm7211-pcie # Broadcom STB version of RPi4 > > - brcm,bcm7216-pcie # Broadcom 7216 Arm > > - brcm,bcm7278-pcie # Broadcom 7278 Arm > > - brcm,bcm7425-pcie # Broadcom 7425 MIPs > > - brcm,bcm7435-pcie # Broadcom 7435 MIPs > > - brcm,bcm7445-pcie # Broadcom 7445 Arm > > - brcm,bcm7712-pcie # Broadcom STB sibling of Rpi 5 > > > > If "stb" means "set top box", it sounds like a catchall for disparate > > devices, which isn't permitted. > > Unlike PCIe, the HW spinlock hardware has been stable across all Set-top box > chips ever since it was added, which is why the catch all is IMHO adequate > here.
I see. Now that I look more, there are other places where "stb" is used. Sounds like "brcmstb" as generic fallback would probably be okay then. Either way, the duplicate 1/3 patch needs to be sorted out.
signature.asc
Description: PGP signature
