On 9/29/25 01:07, Berg, Johannes wrote:
+Miri
Hi Shuah,
I am seeing the following error during "kunit.py run --alltests run"
next-20250926.
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit
--jobs=16
ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in
function `devinfo_pci_ids_config':
devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
collect2: error: ld returned 1 exit status
make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped]
Error 1
make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2
Yeah, really my mistake, I didn't consider what happens in the test there when
iwlwifi is built but without CONFIG_IWLMVM and CONFIG_IWLMLD.
I think we should add those to actually run their kunit tests too, which would
fix the build issue, and maybe even CONFIG_IWLDVM to increase coverage of the
tests in iwlwifi itself. I can send a patch for that.
All that said, the patch that breaks it is in linux-next via iwlwifi-next but
seems to actually have missed the cutoff for 6.18, so we're good for now and I
suppose Miri can even squash the build fix into that later.
Thank you. Sounds like a plan.
I will send my kunit pr to Linus then.
thanks,
-- Shuah
