Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
On Wed, 1 Oct 2025 18:01:08 +0530 you wrote:
> Fix functions that return undefined values. These issues were caught by
> running clang using LLVM=1 option.
>
> Clang warnings are as follows:
> ovpn-cli.c:1587:6: warning: variable 'ret' is used uninitialized whenever
> 'if' condition is true [-Wsometimes-uninitialized]
> 1587 | if (!sock) {
> | ^~~~~
> ovpn-cli.c:1635:9: note: uninitialized use occurs here
> 1635 | return ret;
> | ^~~
> ovpn-cli.c:1587:2: note: remove the 'if' if its condition is always false
> 1587 | if (!sock) {
> | ^~~~~~~~~~~~
> 1588 | fprintf(stderr, "cannot allocate netlink socket\n");
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1589 | goto err_free;
> | ~~~~~~~~~~~~~~
> 1590 | }
> | ~
> ovpn-cli.c:1584:15: note: initialize the variable 'ret' to silence this
> warning
> 1584 | int mcid, ret;
> | ^
> | = 0
> ovpn-cli.c:2107:7: warning: variable 'ret' is used uninitialized whenever
> switch case is taken [-Wsometimes-uninitialized]
> 2107 | case CMD_INVALID:
> | ^~~~~~~~~~~
> ovpn-cli.c:2111:9: note: uninitialized use occurs here
> 2111 | return ret;
> | ^~~
> ovpn-cli.c:1939:12: note: initialize the variable 'ret' to silence this
> warning
> 1939 | int n, ret;
> | ^
> |
>
> [...]
Here is the summary with links:
- [net,v6] selftest:net:ovpn: Fix uninit return values
https://git.kernel.org/netdev/net/c/7fc25c5a5ae6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
