> -----Original Message-----
> From: Andrew Lunn <[email protected]>
> Sent: Monday, October 13, 2025 11:56 AM
> To: Shenwei Wang <[email protected]>
> Cc: Bjorn Andersson <[email protected]>; Mathieu Poirier
> <[email protected]>; Rob Herring <[email protected]>; Krzysztof
> Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Shawn
> Guo <[email protected]>; Sascha Hauer <[email protected]>; Linus
> Walleij <[email protected]>; Bartosz Golaszewski <[email protected]>;
> Pengutronix Kernel Team <[email protected]>; Fabio Estevam
> <[email protected]>; Peng Fan <[email protected]>; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; 
> dl-linux-imx
> <[email protected]>
> Subject: [EXT] Re: [PATCH v3 3/4] gpio: imx-rpmsg: add imx-rpmsg GPIO driver
> > > Notice how ENOPNOTSUPP can be 45, 122, 223, or 95. Returning
> > > EL2NSYNC or EDQUOT to user space is going to cause confusion...
> > >
> >
> 
> > I think we should just follow the definitions in
> > include/uapi/asm-generic/errno.h, right?
> 
> No.
> 
> Try a make for mips, and look at includes you end up with. You will find it 
> goes
> something like:
> 
> # 1 "./arch/mips/include/asm/errno.h" 1
> # 11 "./arch/mips/include/asm/errno.h"
> # 1 "./arch/mips/include/uapi/asm/errno.h" 1 # 16
> "./arch/mips/include/uapi/asm/errno.h"
> # 1 "./include/uapi/asm-generic/errno-base.h" 1 # 17
> "./arch/mips/include/uapi/asm/errno.h" 2
> 
> and this results in
> 
> #define EOPNOTSUPP      122     /* Operation not supported on transport
> endpoint */
> 
> not what you get from asm-generic/errno.h:
> 
> #define EOPNOTSUPP      95      /* Operation not supported on transport 
> endpoint
> */
> 

That shouldn't be an issue in this case. 
For instance, if we define the error code as 1 in the return message, the 
driver will interpret it and just return -EOPNOTSUPP, regardless of the 
architecture.

Thanks,
Shenwei

>         Andrew

Reply via email to