On Fri, Sep 26, 2025 at 08:33:14PM +0800, Peng Fan wrote: > Tested on > i.MX8MP-EVK, i.MX8MM-EVK, i.MX93-11x11-EVK, i.MX8QXP-MEK, and i.MX8ULP-EVK. > > Retested all the patches for V3 on above platforms. And pass build > with patch incremental applied with ARM64 defconfig. pass build for > imx_v6_v7_defconfig with all patches applied. > > This is the 2nd series to cleanup the driver. > > Patch 1: > Fix the runtime usage. This is not critical bug fix, so it could be > defered to 6.18. > > Patch 2-6: > Use devres managed API to cleanup the error handling path and remove path. > > Thanks to Ulf for the suggestion on the runtime PM fix in patch 1. > Thanks to Daniel and Frank for the internal reviewing. > > Signed-off-by: Peng Fan <[email protected]> > > Signed-off-by: Peng Fan <[email protected]> > --- > Changes in v3: > - Follow Ulf's suggestion to address the runtime PM in patch 1, and add > Ulf's suggested-by tag. I dropped Frank and Daniel's tag in patch 1. > - With the changes in patch 1, the remove() is kept, then there are very > minor conflicts when picking remaining patches in V2, so I still keep > R-b tag from Frank and Daniel for patch 2-6. > - Link to v2: > https://lore.kernel.org/r/[email protected] > > Changes in v2: > - Address a build warning in patch 4/6 > - Add R-b from Frank and Daniel > - Link to v1: > https://lore.kernel.org/r/[email protected] > > --- > Peng Fan (6): > remoteproc: imx_rproc: Fix runtime PM cleanup and improve remove path > remoteproc: imx_rproc: Use devm_add_action_or_reset() for workqueue > cleanup > remoteproc: imx_rproc: Use devm_add_action_or_reset() for mailbox > cleanup > remoteproc: imx_rproc: Use devm_clk_get_enabled() and simplify cleanup > remoteproc: imx_rproc: Use devm_add_action_or_reset() for scu cleanup > remoteproc: imx_rproc: Use devm_rproc_add() helper > > drivers/remoteproc/imx_rproc.c | 100 > +++++++++++++++++++---------------------- > 1 file changed, 47 insertions(+), 53 deletions(-)
I will apply this set when 6.18-rc1 comes out. Mathieu > --- > base-commit: 8e2755d7779a95dd61d8997ebce33ff8b1efd3fb > change-id: 20250926-imx_rproc_v3-a50abed3288a > > Best regards, > -- > Peng Fan <[email protected]> >
