On 14/09/2025 14:29, Xiangzhi Tang wrote: > Add the new binding document for MediaTek Video Companion > Processor(VCP) on MediaTek mt8196. > > Signed-off-by: Xiangzhi Tang <[email protected]> > --- > .../remoteproc/mediatek,mt8196-vcp.yaml | 165 ++++++++++++++++++ > 1 file changed, 165 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml > > diff --git > a/Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml > b/Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml > new file mode 100644 > index 000000000000..71a55943843b > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml > @@ -0,0 +1,165 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/mediatek,mt8196-vcp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Video Companion Processor (VCP) > + > +maintainers: > + - Xiangzhi Tang <[email protected]> > + > +description: > + The MediaTek VCP enables the SoC control the MediaTek Video Companion > Risc-V coprocessor.
You keep ignoring comments. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8196-vcp > + > + reg: > + items: > + - description: sram base > + - description: cfg group IO > + - description: cfg core group IO > + - description: cfg sec group IO > + - description: vcp rdy group IO > + > + reg-names: > + items: > + - const: sram Why would sram be the first, main address of this device? Not the address space responsible for configuring it? > + - const: cfg > + - const: cfg_core > + - const: cfg_sec > + - const: vcp_vlp_ao_rsvd7 > + > + interrupts: > + maxItems: 1 > + > + mboxes: > + maxItems: 5 > + > + mbox-names: > + maxItems: 5 Not much improved, more ignored comments and since the changelog is so vague I am afraid you just skimmed through the comments and you just ignored many of them. Implement entire feedback and provide detailed changelog. Best regards, Krzysztof
