Re: [PATCH v10 12/21] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration

[Binbin Wu]

On 9/4/2025 2:54 PM, Sagi Shahar wrote:

From: Isaku Yamahata <isaku.yamah...@intel.com>

Make sure that all the attributes enabled by the test are reported as
supported by the TDX module.

This also exercises the KVM_TDX_CAPABILITIES ioctl.

Signed-off-by: Isaku Yamahata <isaku.yamah...@intel.com>
Co-developed-by: Sagi Shahar <sa...@google.com>
Signed-off-by: Sagi Shahar <sa...@google.com>
---
  tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c 
b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
index aa0cb6c2205b..1b5c01faf1cd 100644
--- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
+++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
@@ -234,6 +234,18 @@ static void vm_tdx_filter_cpuid(struct kvm_vm *vm,
        free(tdx_cap);
  }

+static void tdx_check_attributes(struct kvm_vm *vm, uint64_t attributes)

+{
+       struct kvm_tdx_capabilities *tdx_cap;
+
+       tdx_cap = tdx_read_capabilities(vm);
+
+       /* Make sure all the attributes are reported as supported by the TDX 
module */

I think "by the TDX module" can be dropped, since KVM only reports the
attributes it supports.

+       TEST_ASSERT_EQ(attributes & tdx_cap->supported_attrs, attributes);
+
+       free(tdx_cap);
+}
+
  void vm_tdx_init_vm(struct kvm_vm *vm, uint64_t attributes)
  {
        struct kvm_tdx_init_vm *init_vm;
@@ -253,6 +265,8 @@ void vm_tdx_init_vm(struct kvm_vm *vm, uint64_t attributes)
        memcpy(&init_vm->cpuid, cpuid, kvm_cpuid2_size(cpuid->nent));
        free(cpuid);

+ tdx_check_attributes(vm, attributes);

+
        init_vm->attributes = attributes;

vm_tdx_vm_ioctl(vm, KVM_TDX_INIT_VM, 0, init_vm);