Thanks David for your insightful review comments.
On Tue, Aug 5, 2025 at 1:47 AM David Hildenbrand <[email protected]> wrote: > > On 05.08.25 03:36, Sudarsan Mahendran wrote: > > Enable these tests to be run on other pfnmap'ed memory like > > NVIDIA's EGM. > > > > Add '--' as a separator to pass in file path. This allows > > passing of cmd line arguments to kselftest_harness. > > Use '/dev/mem' as default filename. > > > > Existing test passes: > > pfnmap > > TAP version 13 > > 1..6 > > # Starting 6 tests from 1 test cases. > > # PASSED: 6 / 6 tests passed. > > # Totals: pass:6 fail:0 xfail:0 xpass:0 skip:0 error:0 > > > > Pass params to kselftest_harness: > > pfnmap -r pfnmap:mremap_fixed > > TAP version 13 > > 1..1 > > # Starting 1 tests from 1 test cases. > > # RUN pfnmap.mremap_fixed ... > > # OK pfnmap.mremap_fixed > > ok 1 pfnmap.mremap_fixed > > # PASSED: 1 / 1 tests passed. > > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > > > Pass non-existent file name as input: > > pfnmap -- /dev/blah > > TAP version 13 > > 1..6 > > # Starting 6 tests from 1 test cases. > > # RUN pfnmap.madvise_disallowed ... > > # SKIP Cannot open '/dev/blah' > > > > Pass non pfnmap'ed file as input: > > pfnmap -r pfnmap.madvise_disallowed -- randfile.txt > > TAP version 13 > > 1..1 > > # Starting 1 tests from 1 test cases. > > # RUN pfnmap.madvise_disallowed ... > > # SKIP Invalid file: 'randfile.txt'. Not pfnmap'ed > > > > Signed-off-by: Sudarsan Mahendran <[email protected]> > > --- > > Thanks! > > Acked-by: David Hildenbrand <[email protected]> > > -- > Cheers, > > David / dhildenb >
