> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Stanislav Fomichev
> Sent: Tuesday, June 10, 2025 7:15 PM
> To: [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; GR-Linux-NIC-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; oss-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH net-next v3 2/4] net: remove
> redundant ASSERT_RTNL() in queue setup functions
> 
> The existing netdev_ops_assert_locked() already asserts that either
> the RTNL lock or the per-device lock is held, making the explicit
> ASSERT_RTNL() redundant.
> 
> Cc: Michael Chan <[email protected]>
> Signed-off-by: Stanislav Fomichev <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>

> ---
>  net/core/dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c index
> be97c440ecd5..72997636b8ec 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3179,7 +3179,6 @@ int netif_set_real_num_tx_queues(struct
> net_device *dev, unsigned int txq)
> 
>       if (dev->reg_state == NETREG_REGISTERED ||
>           dev->reg_state == NETREG_UNREGISTERING) {
> -             ASSERT_RTNL();
>               netdev_ops_assert_locked(dev);
> 
>               rc = netdev_queue_update_kobjects(dev, dev-
> >real_num_tx_queues, @@ -3229,7 +3228,6 @@ int
> netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
>               return -EINVAL;
> 
>       if (dev->reg_state == NETREG_REGISTERED) {
> -             ASSERT_RTNL();
>               netdev_ops_assert_locked(dev);
> 
>               rc = net_rx_queue_update_kobjects(dev, dev-
> >real_num_rx_queues,
> --
> 2.49.0


Reply via email to