Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

[Bryan O'Donoghue]

On 26/05/2025 17:20, Vincent Knecht wrote:

You have both

if (vfe->res->has_vbif) {

and the above switch, there's no point in checking this twice in two
different ways.

Choose one, suggest has_vbif is enough.

I think the switch is still needed, so that distinct settings
can be applied for different SoCs.

Or should I just apply the 8939 settings unconditionally, and keep it
as an exercice for the next dev who need other settings for another SoC
to deal with ? 🙂

Thanks

The flag should be enough.

---
bod