On Sun, Nov 10, 2024 at 09:52:32PM +0200, Andy Shevchenko wrote:
> Sun, Nov 10, 2024 at 02:14:24PM -0500, Aren kirjoitti:
> > On Mon, Nov 04, 2024 at 10:40:16AM +0200, Andy Shevchenko wrote:
> > > On Sat, Nov 02, 2024 at 03:50:41PM -0400, Aren Moynihan wrote:
>
> ...
>
> > > > #define STK3310_REGFIELD(name)
> > > > \
> > > > do {
> > > > \
> > > > data->reg_##name =
> > > > \
> > > > - devm_regmap_field_alloc(&client->dev, regmap,
> > > > \
> > > > + devm_regmap_field_alloc(dev, regmap,
> > > > \
> > > > stk3310_reg_field_##name);
> > > > \
> > > > - if (IS_ERR(data->reg_##name)) {
> > > > \
> > > > - dev_err(&client->dev, "reg field alloc
> > > > failed.\n"); \
> > > > - return PTR_ERR(data->reg_##name);
> > > > \
> > > > - }
> > > > \
> > > > + if (IS_ERR(data->reg_##name))
> > > > \
> > >
> > > > + return dev_err_probe(dev,
> > > > \
> > > > + PTR_ERR(data->reg_##name),
> > > > \
> > >
> > > AFAICS these two can be put on one.
> >
> > This doesn't leave room for whitespace between the end of line and "\",
>
> Is it a problem?
It feels a bit camped and not as readable to me:
#define STK3310_REGFIELD(name) \
do { \
data->reg_##name = \
devm_regmap_field_alloc(dev, regmap, \
stk3310_reg_field_##name); \
if (IS_ERR(data->reg_##name)) \
return dev_err_probe(dev, PTR_ERR(data->reg_##name),\
"reg field alloc failed.\n"); \
} while (0)
Removing a level of indentation makes it much better
#define STK3310_REGFIELD(name) ({
\
data->reg_##name = devm_regmap_field_alloc(dev, regmap,
\
stk3310_reg_field_##name);
\
if (IS_ERR(data->reg_##name))
\
return dev_err_probe(dev, PTR_ERR(data->reg_##name),
\
"reg field alloc failed\n");
\
})
> > replacing "do { } while (0)" with "({ })" and deindenting could make
> > enough room to clean this up the formatting of this macro though.
>
> do {} while (0) is C standard, ({}) is not.
({ }) is used throughout the kernel, and is documented as such[1]. I
don't see a reason to avoid it, if it helps readability.
1: the "GNU Extensions" section of Documentation/kernel-hacking/hacking.rst
- Aren
