On Sun 2024-06-16 20:55:41, Markus Elfring wrote: > > The SY7802 is a current-regulated charge pump which can regulate two > > current levels for Flash and Torch modes. > > > > It is a high-current synchronous boost converter with 2-channel high > > side current sources. Each channel is able to deliver 900mA current. > > Would you like to improve such a change description with imperative wordings? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94 >
Feel free to ignore this.
> …
> > +++ b/drivers/leds/flash/leds-sy7802.c
> > @@ -0,0 +1,542 @@
> …
> > +static int sy7802_strobe_get(struct led_classdev_flash *fl_cdev, bool
> > *state)
> > +{
> …
> > + mutex_lock(&chip->mutex);
> > + *state = !!(chip->fled_strobe_used & BIT(led->led_id));
> > + mutex_unlock(&chip->mutex);
> > +
> > + return 0;
> > +}
> …
>
> Would you become interested to apply a statement like
> “guard(mutex)(&chip->mutex);”?
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
This does not look like real improvement for code this trivial.
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
