On Tue, Mar 26, 2024 at 10:28 AM Jakub Kicinski <[email protected]> wrote: > > On Mon, 25 Mar 2024 11:29:18 +0100 Balazs Scheidler wrote: > > + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6)); > > + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6)); > > Indent with tabs please, checkpatch says: > > ERROR: code indent should use tabs where possible > #59: FILE: include/trace/events/udp.h:38: > + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$ > > WARNING: please, no spaces at the start of a line > #59: FILE: include/trace/events/udp.h:38: > + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$ > > ERROR: code indent should use tabs where possible > #60: FILE: include/trace/events/udp.h:39: > + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$ > > WARNING: please, no spaces at the start of a line > #60: FILE: include/trace/events/udp.h:39: > + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$
More than this, it would be better to put "From Balazs Scheidler <[email protected]>" in the first line of each patch to eliminate the mismatched email address warning. Link (Jakub referred to): https://patchwork.kernel.org/project/netdevbpf/patch/34a9c221a6d644f18c826a1beddba58af6b7a64c.1711361723.git.balazs.scheid...@axoflow.com/ Detailed info: https://netdev.bots.linux.dev/static/nipa/837832/13601927/checkpatch/stdout > -- > pw-bot: cr
