Re: [PATCH] nvdimm: of_pmem: Add kfree for kstrdup

[Dave Jiang]

On 8/27/23 23:23, Chen Ni wrote:

Add kfree() for kstrdup() in order to avoid memory leak.

Signed-off-by: Chen Ni <nic...@iscas.ac.cn>

Can you please add a fixes tag? Thanks!

---
  drivers/nvdimm/of_pmem.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
index 10dbdcdfb9ce..fe6edb7e6631 100644
--- a/drivers/nvdimm/of_pmem.c
+++ b/drivers/nvdimm/of_pmem.c
@@ -31,11 +31,17 @@ static int of_pmem_region_probe(struct platform_device 
*pdev)
                return -ENOMEM;

priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);

+       if (!priv->bus_desc.provider_name) {
+               kfree(priv);
+               return -ENOMEM;
+       }
+
        priv->bus_desc.module = THIS_MODULE;
        priv->bus_desc.of_node = np;

priv->bus = bus = nvdimm_bus_register(&pdev->dev, &priv->bus_desc);

        if (!bus) {
+               kfree(priv->bus_desc.provider_name);
                kfree(priv);
                return -ENODEV;
        }