On Mon, Jan 24, 2022 at 3:36 PM Christoph Hellwig <[email protected]> wrote:
>
> On Fri, Jan 21, 2022 at 03:55:13PM +0800, Muchun Song wrote:
> > + if (pvmw->pte && ((pvmw->flags & PVMW_PFN_WALK) ||
> > !PageHuge(pvmw->page)))
>
> Please avoid the overly long line here and in a few other places.
OK.
>
> > +/*
> > + * Then at what user virtual address will none of the page be found in vma?
>
> Doesn't parse, what is this trying to say?
Well, I am also confused.
BTW, this is not introduced by me, it is introduced by:
commit 37ffe9f4d7ff ("mm/thp: fix vma_address() if virtual address
below file offset")
If it is really confusing, I can replace this line with:
"Return the end user virtual address of a page within a vma"
Thanks.
