On Thu, 15 Apr 2021, Uwe Kleine-König wrote: > Hello Lee, > > nitpick: You move range_ni_E_ao_ext to the header. However that header > doesn't use range_ni_E_ao_ext, so the subject is technically wrong.
It's implicitly used by the users of the header. But I know what you mean. I'll see if I can make the subject line a little more clear. > On Wed, Apr 14, 2021 at 07:11:27PM +0100, Lee Jones wrote: > > ... and mark it as __maybe_unused since not all users of the > > header file reference it. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/staging/comedi/drivers/ni_mio_common.c:163:35: warning: > > ‘range_ni_E_ao_ext’ defined but not used [-Wunused-const-variable=] > > > > Cc: Ian Abbott <[email protected]> > > Cc: H Hartley Sweeten <[email protected]> > > Cc: Greg Kroah-Hartman <[email protected]> > > Cc: Thierry Reding <[email protected]> > > Cc: "Uwe Kleine-König" <[email protected]> > > Cc: Lee Jones <[email protected]> > > Cc: "David A. Schleef" <[email protected]> > > Cc: Mori Hess <[email protected]> > > Cc: Truxton Fulton <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Signed-off-by: Lee Jones <[email protected]> > > --- > > drivers/staging/comedi/drivers/ni_mio_common.c | 9 --------- > > drivers/staging/comedi/drivers/ni_stc.h | 9 ++++++++- > > 2 files changed, 8 insertions(+), 10 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
