Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

[luojiaxing]

On 2021/4/3 0:03, Bart Van Assche wrote:

On 4/2/21 2:08 AM, Luo Jiaxing wrote:

-static struct flash_command flash_command_table[] =
-{
+static struct flash_command flash_command_table[] = {
       {"set_nvmd",    FLASH_CMD_SET_NVMD},
       {"update",      FLASH_CMD_UPDATE},
       {"",            FLASH_CMD_NONE} /* Last entry should be NULL. */

Can 'flash_command_table' be declared const?

Sure

-static struct error_fw flash_error_table[] =
-{
+static struct error_fw flash_error_table[] = {
       {"Failed to open fw image file",       FAIL_OPEN_BIOS_FILE},
       {"image header mismatch",              FLASH_UPDATE_HDR_ERR},
       {"image offset mismatch",              FLASH_UPDATE_OFFSET_ERR},

Can 'flash_error_table' be declared const?

Sure


Thanks

Jiaxing

Thanks,

Bart.

.