On Fri, Mar 26, 2021 at 12:38:39PM +0100, Peter Zijlstra wrote: > On Fri, Mar 26, 2021 at 12:30:24PM +0100, Greg KH wrote: > > Great, change that and limit the size of the string that can be written > > and it looks good to me, thanks for adding this. > > Here goes..
Great, except one tiny thing: > + * This function will return a pointer to a dentry if it succeeds. This > + * pointer must be passed to the debugfs_remove() function when the file is > + * to be removed (no automatic cleanup happens if your module is unloaded, > + * you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be > + * returned. > + * > + * NOTE: when writing is enabled it will replace the string, string lifetime > is > + * assumed to be RCU managed. > + * > + * If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will > + * be returned. Nothing is returned anymore so the top and bottom paragraphs here no longer apply. Fix that up and feel free to add: Reviewed-by: Greg Kroah-Hartman <[email protected]> thanks, greg k-h
