On 08/03/2021 16:29, Arnd Bergmann wrote: > From: Arnd Bergmann <[email protected]> > > Some of the extcon interfaces have a fallback implementation that can > be used when EXTCON is disabled, but some others do not, causing a > build failure: > > drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of > function 'devm_extcon_register_notifier_all' > [-Werror,-Wimplicit-function-declaration] > ret = devm_extcon_register_notifier_all(&pdev->dev, > charger->edev, > ^ > drivers/power/supply/max8997_charger.c:261:9: note: did you mean > 'devm_extcon_register_notifier'? > include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier' declared > here > static inline int devm_extcon_register_notifier(struct device *dev, > > I assume there is no reason to actually build this driver without extcon > support, so a hard dependency is the easiest fix. Alternatively the > header file could be extended to provide additional inline stubs.
Hi Arnd, Thanks for the patch but I think I got it covered with: https://lore.kernel.org/lkml/[email protected]/ (sent via extcon tree). Did you experience a new/different issue? Best regards, Krzysztof

