On Wed, Feb 24, 2021 at 3:14 AM Rob Herring <[email protected]> wrote: > > Including the generated syscall headers in 'targets' is wrong because they > are not built in $(obj)/ and the Makefile does its own path prefix and > build rules. > > Cc: Andy Lutomirski <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: [email protected] > Cc: "H. Peter Anvin" <[email protected]> > Cc: Masahiro Yamada <[email protected]> > Cc: Michal Marek <[email protected]> > Signed-off-by: Rob Herring <[email protected]> > --- > arch/x86/entry/syscalls/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/entry/syscalls/Makefile > b/arch/x86/entry/syscalls/Makefile > index 6fb9b57ed5ba..b0dcb7e41554 100644 > --- a/arch/x86/entry/syscalls/Makefile > +++ b/arch/x86/entry/syscalls/Makefile > @@ -62,8 +62,6 @@ syshdr-$(CONFIG_X86_64) += unistd_32_ia32.h > unistd_64_x32.h > syshdr-$(CONFIG_X86_64) += syscalls_64.h > syshdr-$(CONFIG_XEN) += xen-hypercalls.h > > -targets += $(uapisyshdr-y) $(syshdr-y) > -
This is also a wrong fix. The correct fix exists in linux-next. commit 865fa29f7dd1b6af8498fe08f19b4028c1c8a153 Author: Masahiro Yamada <[email protected]> Date: Mon Feb 15 09:48:22 2021 +0900 arch: syscalls: add missing FORCE and fix 'targets' to make if_changed work I will send a PR this week. > PHONY += all > all: $(addprefix $(uapi)/,$(uapisyshdr-y)) > all: $(addprefix $(out)/,$(syshdr-y)) > -- > 2.27.0 > -- Best Regards Masahiro Yamada
