On Mon, Feb 15, 2021 at 02:42:58PM -0800, Saravana Kannan wrote: > When CONFIG_OF_IRQ is not defined, it doesn't make sense to parse > interrupts property. > > Also, parsing and tracking interrupts property breaks some PPC > devices[1]. But none of the IRQ drivers in PPC seem ready to be > converted to a proper platform (or any bus) driver. So, there's not much > of a point in tracking the interrupts property for CONFIG_PPC. So, let's > stop parsing interrupts for CONFIG_PPC. > > [1] - https://lore.kernel.org/lkml/[email protected]/ > Fixes: 4104ca776ba3 ("of: property: Add fw_devlink support for interrupts") > Reported-by: Guenter Roeck <[email protected]> > Signed-off-by: Saravana Kannan <[email protected]>
That does the trick, at least for my test cases. Tested-by: Guenter Roeck <[email protected]> Guenter > --- > Greg/Rob, > > I believe this needs to land on driver-core-next. > > -Saravana > > drivers/of/property.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 79b68519fe30..5036a362f52e 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1300,6 +1300,9 @@ static struct device_node *parse_interrupts(struct > device_node *np, > { > struct of_phandle_args sup_args; > > + if (!IS_ENABLED(CONFIG_OF_IRQ) || IS_ENABLED(CONFIG_PPC)) > + return NULL; > + > if (strcmp(prop_name, "interrupts") && > strcmp(prop_name, "interrupts-extended")) > return NULL; > -- > 2.30.0.478.g8a0d178c01-goog >
