On 08/01/21 12:28, Greg KH wrote:
static void __iomem *base;
+static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
+module_param(capability, uint, 0444);
+MODULE_PARM_DESC(capability, "capability of pvpanic device");
This is not the 1990's, please do not add new module parameters:(
Note that the parameter can also be used to _limit_ which capabilities
the driver uses:
v1:
+ /* initlize capability by RDPT */
+ capability = ioread8(base);
v2:
+ /* initlize capability by RDPT */
+ capability &= ioread8(base);
Of course it would have helped if there was a summary of v1->v2 changes
in the message. :)
Paolo
Use sysfs, and properly document the file in Documentation/ABI/
