The following commit has been merged into the irq/irqchip-next branch of 
irqchip:

Commit-ID:     b16a1caf4686895427c810219d4b2f796e676160
Gitweb:        
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/b16a1caf4686895427c810219d4b2f796e676160
Author:        Hou Zhiqiang <[email protected]>
AuthorDate:    Mon, 30 Nov 2020 18:15:05 +08:00
Committer:     Marc Zyngier <[email protected]>
CommitterDate: Fri, 11 Dec 2020 14:43:16 

irqchip/ls-extirq: Add LS1043A, LS1088A external interrupt support

Add an new IRQ chip declaration for LS1043A and LS1088A, and cleanup
the use of the "bit_reverse" property, now gated on the Soc type.

Signed-off-by: Hou Zhiqiang <[email protected]>
Signed-off-by: Biwen Li <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
 drivers/irqchip/irq-ls-extirq.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c
index 4d1179f..f94f974 100644
--- a/drivers/irqchip/irq-ls-extirq.c
+++ b/drivers/irqchip/irq-ls-extirq.c
@@ -18,7 +18,7 @@
 struct ls_extirq_data {
        struct regmap           *syscon;
        u32                     intpcr;
-       bool                    bit_reverse;
+       bool                    is_ls1021a_or_ls1043a;
        u32                     nirq;
        struct irq_fwspec       map[MAXIRQ];
 };
@@ -30,7 +30,7 @@ ls_extirq_set_type(struct irq_data *data, unsigned int type)
        irq_hw_number_t hwirq = data->hwirq;
        u32 value, mask;
 
-       if (priv->bit_reverse)
+       if (priv->is_ls1021a_or_ls1043a)
                mask = 1U << (31 - hwirq);
        else
                mask = 1U << hwirq;
@@ -174,14 +174,8 @@ ls_extirq_of_init(struct device_node *node, struct 
device_node *parent)
        if (ret)
                goto out;
 
-       if (of_device_is_compatible(node, "fsl,ls1021a-extirq")) {
-               u32 revcr;
-
-               ret = regmap_read(priv->syscon, LS1021A_SCFGREVCR, &revcr);
-               if (ret)
-                       goto out;
-               priv->bit_reverse = (revcr != 0);
-       }
+       priv->is_ls1021a_or_ls1043a = of_device_is_compatible(node, 
"fsl,ls1021a-extirq") ||
+                                     of_device_is_compatible(node, 
"fsl,ls1043a-extirq");
 
        domain = irq_domain_add_hierarchy(parent_domain, 0, priv->nirq, node,
                                          &extirq_domain_ops, priv);
@@ -195,3 +189,5 @@ out:
 }
 
 IRQCHIP_DECLARE(ls1021a_extirq, "fsl,ls1021a-extirq", ls_extirq_of_init);
+IRQCHIP_DECLARE(ls1043a_extirq, "fsl,ls1043a-extirq", ls_extirq_of_init);
+IRQCHIP_DECLARE(ls1088a_extirq, "fsl,ls1088a-extirq", ls_extirq_of_init);

Reply via email to