> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Tuesday, December 8, 2020 12:35 AM
> To: Krzysztof Kozlowski <[email protected]>; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: Sylwester Nawrocki <[email protected]>; Marek Szyprowski
> <[email protected]>; Bartlomiej Zolnierkiewicz
> <[email protected]>; Arnd Bergmann <[email protected]>; Chanwoo
> Choi <[email protected]>; Alim Akhtar <[email protected]>;
> Pankaj Dubey <[email protected]>; [email protected]
> Subject: [PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on
not-
> supported SoCs
>
> From: Marek Szyprowski <[email protected]>
>
> Check if the SoC is really supported before gathering the needed
resources.
> This fixes endless deferred probe on some SoCs other than
> Exynos5422 (like Exynos5410).
>
> Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage
> driver")
> Cc: <[email protected]>
> Signed-off-by: Marek Szyprowski <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/soc/samsung/exynos-asv.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/samsung/exynos-asv.c
> b/drivers/soc/samsung/exynos-asv.c
> index 8abf4dfaa5c5..f653e3533f0f 100644
> --- a/drivers/soc/samsung/exynos-asv.c
> +++ b/drivers/soc/samsung/exynos-asv.c
> @@ -119,11 +119,6 @@ static int exynos_asv_probe(struct platform_device
> *pdev)
> u32 product_id = 0;
> int ret, i;
>
> - cpu_dev = get_cpu_device(0);
> - ret = dev_pm_opp_get_opp_count(cpu_dev);
> - if (ret < 0)
> - return -EPROBE_DEFER;
> -
> asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL);
> if (!asv)
> return -ENOMEM;
> @@ -144,6 +139,11 @@ static int exynos_asv_probe(struct platform_device
> *pdev)
> return -ENODEV;
> }
>
> + cpu_dev = get_cpu_device(0);
> + ret = dev_pm_opp_get_opp_count(cpu_dev);
> + if (ret < 0)
> + return -EPROBE_DEFER;
> +
> ret = of_property_read_u32(pdev->dev.of_node, "samsung,asv-
> bin",
> &asv->of_bin);
> if (ret < 0)
> --
> 2.25.1
Reviewed-by: Pankaj Dubey <[email protected]>
