Hi Colin, Thanks for catching this!
On 2020-12-04 17:38:33 +0000, Colin King wrote: > From: Colin Ian King <[email protected]> > > Currently the return error code is in ret is being assigned but not > used. It and should be returned by the return statement and currently > just 0 is being returned. Fix this. > > Addresses-Coverity: ("Unused value") > Fixes: b9ad52aafe38 ("media: rcar-vin: Rework parallel firmware parsing") > Signed-off-by: Colin Ian King <[email protected]> Reviewed-by: Niklas Söderlund <[email protected]> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c > b/drivers/media/platform/rcar-vin/rcar-core.c > index 98bff765b02e..e48d666f2c63 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -654,7 +654,7 @@ static int rvin_parallel_parse_of(struct rvin_dev *vin) > out: > fwnode_handle_put(fwnode); > > - return 0; > + return ret; > } > > static int rvin_parallel_init(struct rvin_dev *vin) > -- > 2.29.2 > -- Regards, Niklas Söderlund
