Hi Daniel, I love your patch! Yet something to improve:
[auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.10-rc6 next-20201201] [cannot apply to thermal/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Rename-passive_delay-and-polling_delay-with-units/20201202-201150 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576 config: i386-randconfig-a001-20201202 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/ade78f158731d79d859533d4370cc2a1294be32e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Rename-passive_delay-and-polling_delay-with-units/20201202-201150 git checkout ade78f158731d79d859533d4370cc2a1294be32e # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): drivers/platform/x86/acerhdf.c: In function 'acerhdf_check_param': >> drivers/platform/x86/acerhdf.c:339:12: error: 'struct thermal_zone_device' >> has no member named 'polling_delay'; did you mean 'polling_delay_ms'? 339 | thermal->polling_delay = interval*1000; | ^~~~~~~~~~~~~ | polling_delay_ms vim +339 drivers/platform/x86/acerhdf.c e86435eb91b2bff Peter Feuerer 2009-06-21 322 e86435eb91b2bff Peter Feuerer 2009-06-21 323 static void acerhdf_check_param(struct thermal_zone_device *thermal) e86435eb91b2bff Peter Feuerer 2009-06-21 324 { e86435eb91b2bff Peter Feuerer 2009-06-21 325 if (fanon > ACERHDF_MAX_FANON) { e86435eb91b2bff Peter Feuerer 2009-06-21 326 pr_err("fanon temperature too high, set to %d\n", e86435eb91b2bff Peter Feuerer 2009-06-21 327 ACERHDF_MAX_FANON); e86435eb91b2bff Peter Feuerer 2009-06-21 328 fanon = ACERHDF_MAX_FANON; e86435eb91b2bff Peter Feuerer 2009-06-21 329 } e86435eb91b2bff Peter Feuerer 2009-06-21 330 e86435eb91b2bff Peter Feuerer 2009-06-21 331 if (kernelmode && prev_interval != interval) { e86435eb91b2bff Peter Feuerer 2009-06-21 332 if (interval > ACERHDF_MAX_INTERVAL) { e86435eb91b2bff Peter Feuerer 2009-06-21 333 pr_err("interval too high, set to %d\n", e86435eb91b2bff Peter Feuerer 2009-06-21 334 ACERHDF_MAX_INTERVAL); e86435eb91b2bff Peter Feuerer 2009-06-21 335 interval = ACERHDF_MAX_INTERVAL; e86435eb91b2bff Peter Feuerer 2009-06-21 336 } e86435eb91b2bff Peter Feuerer 2009-06-21 337 if (verbose) eecc5bbc612a8b0 Joe Perches 2011-11-29 338 pr_notice("interval changed to: %d\n", interval); e86435eb91b2bff Peter Feuerer 2009-06-21 @339 thermal->polling_delay = interval*1000; e86435eb91b2bff Peter Feuerer 2009-06-21 340 prev_interval = interval; e86435eb91b2bff Peter Feuerer 2009-06-21 341 } e86435eb91b2bff Peter Feuerer 2009-06-21 342 } e86435eb91b2bff Peter Feuerer 2009-06-21 343 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
