On Wed, Nov 25, 2020 at 1:49 PM Wang ShaoBo <[email protected]> wrote: > > Fix to return proper error code instaed of 0 in cpufreq_online(), as done
s/instaed/instead/ > elsewhere in this function. > > Signed-off-by: Wang ShaoBo <[email protected]> > --- > drivers/cpufreq/cpufreq.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 1e7e3f2ff09f..4645c2b78682 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1391,8 +1391,10 @@ static int cpufreq_online(unsigned int cpu) > > policy->min_freq_req = kzalloc(2 * > sizeof(*policy->min_freq_req), > GFP_KERNEL); > - if (!policy->min_freq_req) > + if (!policy->min_freq_req) { > + ret = -ENOMEM; > goto out_destroy_policy; > + } > > ret = freq_qos_add_request(&policy->constraints, > policy->min_freq_req, FREQ_QOS_MIN, > @@ -1429,6 +1431,7 @@ static int cpufreq_online(unsigned int cpu) > if (cpufreq_driver->get && has_target()) { > policy->cur = cpufreq_driver->get(policy->cpu); > if (!policy->cur) { > + ret = -EINVAL; This error code isn't suitable to be returned from here. -EIO would be better. > pr_err("%s: ->get() failed\n", __func__); > goto out_destroy_policy; > } > --
