On Sun, 11 Oct 2020 at 23:01, Randy Dunlap <[email protected]> wrote: > > kernel test robot reported build errors (undefined references) > that didn't make much sense. After reproducing them, there is also > a Kconfig warning that is the root cause of the build errors, so > fix that Kconfig problem. > > Fixes this Kconfig warning: > WARNING: unmet direct dependencies detected for CMA > Depends on [n]: MMU [=n] > Selected by [m]: > - DRM_ASPEED_GFX [=m] && HAS_IOMEM [=y] && DRM [=m] && OF [=y] && > (COMPILE_TEST [=y] || ARCH_ASPEED) && HAVE_DMA_CONTIGUOUS [=y] > > and these dependent build errors: > (.text+0x10c8c): undefined reference to `start_isolate_page_range' > microblaze-linux-ld: (.text+0x10f14): undefined reference to > `test_pages_isolated' > microblaze-linux-ld: (.text+0x10fd0): undefined reference to > `undo_isolate_page_range' > > Fixes: 76356a966e33 ("drm: aspeed: Clean up Kconfig options") > Reported-by: kernel test robot <[email protected]> > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Joel Stanley <[email protected]> > Cc: Andrew Jeffery <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Michal Simek <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Mike Rapoport <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: David Airlie <[email protected]> > Cc: [email protected] > --- > First sent on 2020-09-07. > Feel free to fix the Kconfig warning some other way...
Reviewed-by: Joel Stanley <[email protected]> Thanks Randy. Sorry for missing it the first time around. I'll merge this into drm-misc-next. Cheers, Joel > > drivers/gpu/drm/aspeed/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20201009.orig/drivers/gpu/drm/aspeed/Kconfig > +++ linux-next-20201009/drivers/gpu/drm/aspeed/Kconfig > @@ -3,6 +3,7 @@ config DRM_ASPEED_GFX > tristate "ASPEED BMC Display Controller" > depends on DRM && OF > depends on (COMPILE_TEST || ARCH_ASPEED) > + depends on MMU > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DMA_CMA if HAVE_DMA_CONTIGUOUS
